fix(ci): drupal integration tests and drupal-contrib validate missing from CI#128
Merged
fix(ci): drupal integration tests and drupal-contrib validate missing from CI#128
Conversation
drupal-contrib/tests/validate.tftest.hcl exists but the template was missing from the validate.yml matrix, so terraform validate and terraform test never ran for it in CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rfay
force-pushed
the
20260507_tests_on_main
branch
from
0737f03 to
e064074
Compare
Both drupal-integration-test and drupal-contrib-integration-test had paths: filters on their push trigger, so they only fired when their respective template dirs changed. Merges touching image/, scripts/, .github/, or VERSION silently skipped them. The pull_request trigger already had no path filter, so this restores symmetry: integration tests now run on every push to main, matching PR behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rfay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drupal-contrib/tests/validate.tftest.hclexists butdrupal-contribwas missing from thevalidate.ymlmatrix —terraform validateandterraform testnever ran for it in CIdrupal-integration-test.ymlanddrupal-contrib-integration-test.ymlhadpaths:filters on their push trigger, so integration tests only fired when their respective template dirs changed — merges touchingimage/,scripts/,.github/, orVERSIONsilently skipped them. PRs already had no path filter, so this was an asymmetry.Test plan
Validate (drupal-contrib)job appears and passes in CI on this PRDrupal Integration TestsandDrupal Contrib Integration Testsappear in CI on this PR🤖 Generated with Claude Code